Disable visualization smoke tests for test mode bypass#11
Merged
Conversation
imaging/visualization.py and interferometer/visualization.py trigger mkdir race conditions and missing file assertions in bypass mode. Disabled pending fix in PyAutoLabs/PyAutoFit#1179. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disables
imaging/visualization.pyandinterferometer/visualization.pyfrom smoke tests — they fail in bypass mode (PYAUTOFIT_TEST_MODE=2) due to mkdir race conditions and missing file assertions.Also adds
smoke_tests.txtto this repo (was previously missing).Scripts Changed
smoke_tests.txt— new file; commented out visualization scripts with notes referencing feat: add sampler bypass modes to PYAUTOFIT_TEST_MODE PyAutoFit#1179Upstream PR
PyAutoLabs/PyAutoFit#1180
Test Plan
🤖 Generated with Claude Code